]> Cypherpunks repositories - gostls13.git/commit
os: invoke processKiller synchronously in testKillProcess
authorBryan C. Mills <bcmills@google.com>
Fri, 15 Jan 2021 15:16:25 +0000 (10:16 -0500)
committerBryan C. Mills <bcmills@google.com>
Fri, 15 Jan 2021 18:29:43 +0000 (18:29 +0000)
commit1deae0b59747ea87d0ef02b6dfdfbbdf5e7bcee8
tree87fd575cd04bf0176fd06ae8a186acfcaa9a1ba5
parentff196c3e84b7e8d47285a0833d0458db3286f8ec
os: invoke processKiller synchronously in testKillProcess

Previously, testKillProcess needlessly invoked processKiller in a
separate goroutine and failed to wait for that goroutine to complete,
causing the calls to t.Fatalf in that goroutine to potentially occur
after the test function had already returned.

Fixes #43722

Change-Id: I5d03cb24af51bb73f0ff96419dac57ec39776967
Reviewed-on: https://go-review.googlesource.com/c/go/+/284153
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/os/os_test.go