]> Cypherpunks repositories - gostls13.git/commit
cmd/go: refuse -w with an invalid GO111MODULE
authorDaniel Martí <mvdan@mvdan.cc>
Sun, 13 Oct 2019 21:33:18 +0000 (22:33 +0100)
committerDaniel Martí <mvdan@mvdan.cc>
Mon, 14 Oct 2019 22:39:28 +0000 (22:39 +0000)
commit1ed932d22b7f602d3aa0a4a5ab12ff479a2c1dce
tree3494bfb107b1cae5ac9d1906a8b467635e16b187
parent90888ed97b5b3c0d104b2e9f28e5b74c1b0d07dd
cmd/go: refuse -w with an invalid GO111MODULE

It was possible to get 'go env' to break itself:

$ go env -w GO111MODULE=bad
$ go env
go: unknown environment setting GO111MODULE=bad

We already check if the variable name is known. In some cases like
GO111MODULE, we also know what the variable's valid values are. Enforce
it when writing the variable, not just when fetching it.

Fixes #34880.

Change-Id: I10d682087c69f3445f314fd4473644f694e255f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/200867
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/envcmd/env.go
src/cmd/go/testdata/script/env_write.txt