]> Cypherpunks repositories - gostls13.git/commit
net/http: don't write HEAD response body in ResponseWriter.ReadFrom
authorDamien Neil <dneil@google.com>
Fri, 26 Jul 2024 20:23:09 +0000 (13:23 -0700)
committerGopher Robot <gobot@golang.org>
Mon, 29 Jul 2024 21:29:55 +0000 (21:29 +0000)
commit1ef6b2805ea1d78c082c7c55df39fc3d3942e4c9
tree8a3a74bfd21e961d9d1d0a04e771cba002c181a0
parentac51262592a20e16afec77163eff98be1d336f5c
net/http: don't write HEAD response body in ResponseWriter.ReadFrom

Responses to HEAD requests don't have a body.

The ResponseWriter automatically discards writes to the response body
when responding to a HEAD request. ResponseWriter.ReadFrom was failing
to discard writes under some circumstances; fix it to do so.

Fixes #68609

Change-Id: I912f6b2b2a535df28ae37b875fcf15b10da1af2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/601475
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/net/http/serve_test.go
src/net/http/server.go