]> Cypherpunks repositories - gostls13.git/commit
cmd/link: fix SCONST symbol handling on darwin
authorCherry Zhang <cherryyz@google.com>
Thu, 14 May 2020 16:16:10 +0000 (12:16 -0400)
committerCherry Zhang <cherryyz@google.com>
Thu, 14 May 2020 16:53:34 +0000 (16:53 +0000)
commit1f325af4dd6c07f899da0a7c0512a7d470cebf9f
tree6ed797f2eb545d750be28d5b7603b44fa9826c04
parent796786cd0cc1ed71da65fe9f1760b390b189c5cd
cmd/link: fix SCONST symbol handling on darwin

Don't include SCONST symbols in the symbol table when
NotInSymbolTable is set. This is what the old code (genasmsym)
does.

In fact, SCONST symbol is only emitted by the field tracking
code, and is always NotInSymbolTable. So we should just not
include them at all, or not generate SCONST symbols at all. But
at this late stage I'll just restore the old behavior.

Change-Id: If6843003e16701d45b8c67b2297098a7babdec52
Reviewed-on: https://go-review.googlesource.com/c/go/+/233997
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/ld/macho.go