]> Cypherpunks repositories - gostls13.git/commit
runtime: don't call lockOSThread for every syscall call on Windows
authorqmuntal <quimmuntal@gmail.com>
Mon, 11 Mar 2024 09:49:44 +0000 (10:49 +0100)
committerGopher Robot <gobot@golang.org>
Tue, 26 Mar 2024 03:12:13 +0000 (03:12 +0000)
commit1f354a60ff7e8e047e4dfecb1033a20ee8c266dc
tree5e706b63cdf85513f00807f3deb945a3c2c8f658
parent3659b8756a2b81766e589e34d4fe9613b5917de0
runtime: don't call lockOSThread for every syscall call on Windows

Windows syscall.SyscallN currently calls lockOSThread for every syscall.
This can be expensive and produce unnecessary context switches,
especially when the syscall is called frequently under high contention.

The lockOSThread was necessary to ensure that cgocall wouldn't
reschedule the goroutine to a different M, as the syscall return values
are reported back in the M struct.

This CL instructs cgocall to copy the syscall return values into the
the M that will see the caller on return, so the caller no longer needs
to call lockOSThread.

Updates #58336.

Cq-Include-Trybots: luci.golang.try:gotip-windows-arm64,gotip-windows-amd64-longtest
Change-Id: If6644fd111dbacab74e7dcee2afa18ca146735da
Reviewed-on: https://go-review.googlesource.com/c/go/+/562915
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Auto-Submit: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/runtime/cgocall.go
src/runtime/nonwindows_stub.go
src/runtime/os_windows.go
src/runtime/runtime2.go
src/runtime/syscall_windows.go