]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.10] cmd/link: put runtime.framepointer_enabled in DATA instead...
authorCherry Zhang <cherryyz@google.com>
Wed, 4 Apr 2018 16:12:10 +0000 (12:12 -0400)
committerAndrew Bonventre <andybons@golang.org>
Mon, 29 Oct 2018 19:25:12 +0000 (19:25 +0000)
commit1f8a5b8cc8f5dca6aaa09cf2a6604a2edd84cb14
tree39a8c794e5fb0a891f7f4b7d53c58f6044aacff2
parent95b56b3879ef1440846ee726f077624878d22432
[release-branch.go1.10] cmd/link: put runtime.framepointer_enabled in DATA instead of RODATA

On darwin, only writable symbol is exported
(cmd/link/internal/ld/macho.go:/machoShouldExport).
For plugin to work correctly, global variables, including
runtime.framepointer_enabled which is set by the linker, need
to be exported when dynamic linking. Put it in DATA so it is
exported. Also in Go it is defined as a var, which is not
read-only.

While here, do the same for runtime.goarm.

Fixes #25038.

Change-Id: I9d1b7d5a648be17103d20b97be65a901cb69f5a2
Reviewed-on: https://go-review.googlesource.com/104715
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-on: https://go-review.googlesource.com/c/122116
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/ld/lib.go