]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.20] cmd/go: remove tests that assume lack of new versions of...
authorBryan C. Mills <bcmills@google.com>
Thu, 9 Feb 2023 21:37:51 +0000 (16:37 -0500)
committerDavid Chase <drchase@google.com>
Fri, 10 Feb 2023 17:29:40 +0000 (17:29 +0000)
commit1fa2deb1b1a620511a3c45fcbae895e78d4f5d40
tree0b8196b4aa5d4d5dcbb0c2c2f92d7953898ae86d
parenta943fd0cccc6043e6a3397659f3f262544e615b2
[release-branch.go1.20] cmd/go: remove tests that assume lack of new versions of external modules

In general it seems ok to assume that an open-source module that did
exist will continue to do so — after all, users of open-source modules
already do that all the time. However, we should not assume that those
modules do not publish new versions — that's really up to their
maintainers to decide.

Two existing tests did make that assumption for the module
gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests.
If we need to replace them at some point, we can replace them with
hermetic test-only modules (#54503) or perhaps modules owned by the Go
project.

Updates #58445.
Fixes #58450.

Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f
Reviewed-on: https://go-review.googlesource.com/c/go/+/466861
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/go/internal/modfetch/coderepo_test.go