]> Cypherpunks repositories - gostls13.git/commit
runtime: remove legacy eager write barrier
authorAustin Clements <austin@google.com>
Mon, 15 Jan 2018 17:27:17 +0000 (12:27 -0500)
committerAustin Clements <austin@google.com>
Tue, 13 Feb 2018 16:34:46 +0000 (16:34 +0000)
commit20101894078199a3a9014ca99ec4e2a0a16a0869
tree8e7ff5c0fcc37243fcd39ba23ea2976503712f63
parent245310883dcae717bb662b22d5b1fd07fdd59b76
runtime: remove legacy eager write barrier

Now that the buffered write barrier is implemented for all
architectures, we can remove the old eager write barrier
implementation. This CL removes the implementation from the runtime,
support in the compiler for calling it, and updates some compiler
tests that relied on the old eager barrier support. It also makes sure
that all of the useful comments from the old write barrier
implementation still have a place to live.

Fixes #22460.

Updates #21640 since this fixes the layering concerns of the write
barrier (but not the other things in that issue).

Change-Id: I580f93c152e89607e0a72fe43370237ba97bae74
Reviewed-on: https://go-review.googlesource.com/92705
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Rick Hudson <rlh@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
24 files changed:
src/cmd/compile/internal/gc/asm_test.go
src/cmd/compile/internal/gc/builtin.go
src/cmd/compile/internal/gc/builtin/runtime.go
src/cmd/compile/internal/gc/go.go
src/cmd/compile/internal/gc/main.go
src/cmd/compile/internal/gc/ssa.go
src/cmd/compile/internal/ssa/config.go
src/cmd/compile/internal/ssa/export_test.go
src/cmd/compile/internal/ssa/writebarrier.go
src/cmd/vet/all/whitelist/386.txt
src/cmd/vet/all/whitelist/all.txt
src/cmd/vet/all/whitelist/amd64.txt
src/cmd/vet/all/whitelist/arm.txt
src/cmd/vet/all/whitelist/arm64.txt
src/cmd/vet/all/whitelist/mips64x.txt
src/cmd/vet/all/whitelist/mipsx.txt
src/cmd/vet/all/whitelist/nacl_amd64p32.txt
src/cmd/vet/all/whitelist/ppc64x.txt
src/cmd/vet/all/whitelist/s390x.txt
src/runtime/asm_amd64.s
src/runtime/mbarrier.go
src/runtime/mwbbuf.go
test/fixedbugs/issue15747.go
test/fixedbugs/issue20250.go