]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.19] os/signal/internal/pty: fix error handling
authorHeschi Kreinick <heschi@google.com>
Wed, 8 Mar 2023 21:48:06 +0000 (16:48 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 8 Mar 2023 22:10:20 +0000 (22:10 +0000)
commit20c96a7ddcd913e7fe627a30c91bcc73b655944c
tree08cf8bc318f12c7b8fb87e642c8a97a1e6c7aa71
parent7bd22aafe41be40e2174335a3dc55431ca9548ec
[release-branch.go1.19] os/signal/internal/pty: fix error handling

When calling a c library function, you discover that an error has
occurred, typically by looking at the return value of the function. Only
after that can you use errno to figure out the cause of the error.

Nothing about cgo changes that story -- you still have to look at the
result before checking the error that represents errno. If not you can
get false errors if the function happens to leak a non-zero errno.

Fix testpty to check errors correctly.

Fixes #58941

Change-Id: I4009e10b344e43fec291b941a63bcf4548937d44
Reviewed-on: https://go-review.googlesource.com/c/go/+/474619
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/os/signal/internal/pty/pty.go