]> Cypherpunks repositories - gostls13.git/commit
encoding/json: get rid of the stream_test.go TODOs
authorDaniel Martí <mvdan@mvdan.cc>
Sun, 26 Aug 2018 14:35:24 +0000 (08:35 -0600)
committerDaniel Martí <mvdan@mvdan.cc>
Sun, 26 Aug 2018 17:09:27 +0000 (17:09 +0000)
commit21af0c1699909454baa4fc6890fe9a1d337faf9c
treefc0da113fd08a13d3dabd7c168486988e4d01740
parenteae5fc88c13d6902a7fe9c595fb02155eb037cbe
encoding/json: get rid of the stream_test.go TODOs

TestRawMessage now passes without the need for the RawMessage field to
be a pointer. The TODO dates all the way back to 2010, so I presume the
issue has since been fixed.

TestNullRawMessage tested the decoding of a JSON null into a
*RawMessage. The existing behavior was correct, but for the sake of
completeness a non-pointer RawMessage field has been added too. The
non-pointer field behaves differently, as one can read in the docs:

To unmarshal JSON into a value implementing the Unmarshaler
interface, Unmarshal calls that value's UnmarshalJSON method,
including when the input is a JSON null.

Change-Id: Iabaed75d4ed10ea427d135ee1b80c6e6b83b2e6e
Reviewed-on: https://go-review.googlesource.com/131377
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/encoding/json/stream_test.go