]> Cypherpunks repositories - gostls13.git/commit
runtime: skip TestCPUMetricsSleep as flaky
authorMichael Anthony Knyszek <mknyszek@google.com>
Wed, 24 May 2023 13:51:33 +0000 (13:51 +0000)
committerMichael Knyszek <mknyszek@google.com>
Wed, 24 May 2023 14:36:25 +0000 (14:36 +0000)
commit220c396ea885158638689fec6db9677d20d568ea
treee53c6a6da942a499106137b0eb51fc321526d487
parent227e7126857df9f73863fc60090976b98fa9dd4e
runtime: skip TestCPUMetricsSleep as flaky

This test is fundamentally flaky because of a mismatch between how
internal idle time is calculated and how the test expects it to be
calculated. It's unclear how to resolve this mismatch, given that it's
perfectly valid for a goroutine to remain asleep while background
goroutines (e.g. the scavenger) run. In practice, we might be able to
set some generous lower-bound, but until we can confirm that on the
affected platforms, skip the test as flaky unconditionally.

For #60276.
For #60376.

Change-Id: Iffd5c4be10cf8ae8a6c285b61fcc9173235fbb2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/497876
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/metrics_test.go