]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.19] cmd/compile/internal/inline: fix latent CalleeEffects issue
authorMatthew Dempsky <mdempsky@google.com>
Mon, 8 Aug 2022 19:31:33 +0000 (12:31 -0700)
committerCherry Mui <cherryyz@google.com>
Mon, 19 Sep 2022 21:52:24 +0000 (21:52 +0000)
commit225bcec98b53ddceeb6998614ad566c11ef27620
treea6f00d7fa3cec475324ba2fbe709f728cec9bf90
parent19d792c1eb4342895f9d41d03ab931e9e26c7d78
[release-branch.go1.19] cmd/compile/internal/inline: fix latent CalleeEffects issue

ir.ClosureExpr implements ir.InitNode, so ir.InitExpr can prepend init
statements to it. However, CalleeEffects wasn't aware of this and
could cause the init statements to get dropped when inlining a call to
a closure.

This isn't an issue today, because we don't create closures with init
statements. But I ran into this within unified IR.

Easy and robust solution: just take advantage that ir.TakeInit can
handle any node.

Fixes #54917.

Change-Id: Ica05fbf6a8c5be4b11927daf84491a1140da5431
Reviewed-on: https://go-review.googlesource.com/c/go/+/422196
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/429896
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/cmd/compile/internal/inline/inl.go
test/fixedbugs/issue54911.go [new file with mode: 0644]