]> Cypherpunks repositories - gostls13.git/commit
cmd/go: remove checks that all counters incremented are in counters.txt
authorMichael Matloob <matloob@golang.org>
Wed, 1 May 2024 17:51:20 +0000 (13:51 -0400)
committerMichael Matloob <matloob@golang.org>
Fri, 3 May 2024 18:15:22 +0000 (18:15 +0000)
commit23f760fd58a0609b9e03da944e7949f7e26a7e29
tree36857432946687cb0696d1ef9588844302dcaa69
parent7b5206bdf37863aee416358b695f6dd2a9f087fc
cmd/go: remove checks that all counters incremented are in counters.txt

This change removes cmd/go/testdata/counters.txt. It also removes the
code that prepares it and checks that it contains all registered
counters as well as counters for all flags and subcommands. It removes
the counter registration mechanism, and uses telemetry.NewCounter to
create new counters instead. It keeps the tests that check that at least
one counter is incremented if the go command is invoked in a script test.

Change-Id: Ic6bda5c64e90f0dd7e221968fce0e375e84d6e17
Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest,gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/582715
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
src/cmd/go/counters_test.go [deleted file]
src/cmd/go/internal/base/base.go
src/cmd/go/internal/help/help.go
src/cmd/go/internal/modfetch/cache.go
src/cmd/go/internal/toolchain/select.go
src/cmd/go/internal/toolchain/switch.go
src/cmd/go/main.go
src/cmd/go/script_test.go
src/cmd/go/testdata/counters.txt [deleted file]