]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: clarify a few redundant deletions of internal/ssagen.state.vars
authorAndy Pan <panjf2000@gmail.com>
Sat, 25 Feb 2023 10:31:13 +0000 (18:31 +0800)
committerGopher Robot <gobot@golang.org>
Thu, 9 Mar 2023 19:25:20 +0000 (19:25 +0000)
commit24017148ca8a669debbddba56d69769dc47d5c71
treea066209ba317f44caf79bf9d438a4966a0cc044a
parent642542cb3c4b672cb34cde44a415c05bf1560a5e
cmd/compile: clarify a few redundant deletions of internal/ssagen.state.vars

Fixes #58729

The reason why these deletions exist is that the old state.variable method
will assign the new value to the given key of map when the key doesn't exist,
but after this commit: https://github.com/golang/go/commit/5a6e511c614a158cb58150fb62bfbc207a33922d#diff-e754f9fc8eaf878714250cfc03844eb3b58185ac806a8c1c4f9fbabd86cda921L3972
the state.variable doesn't do that anymore, thus these deletions became redundant.

Change-Id: Ie6e2471ca445f907a2bb1607c293f9301f0d73e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/471355
Run-TryBot: Andy Pan <panjf2000@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssagen/ssa.go