]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/vcweb: simplify hgHandler cancellation
authorBryan C. Mills <bcmills@google.com>
Tue, 10 Jan 2023 15:38:18 +0000 (10:38 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 19 Jan 2023 20:46:08 +0000 (20:46 +0000)
commit24a9d7bc1834d6a4019a965c759d2282fa029229
tree49064152e5af39f760e255e0f5c59c9c509b10b2
parente08642cae18460778ba3f7808c91cbf6d9ee9f67
cmd/go/internal/vcweb: simplify hgHandler cancellation

This uses the new Cancel and WaitDelay fields of os/exec.Cmd
(added in #50436) to interrupt or kill the 'hg serve' command
when its incoming http.Request is canceled.

This should keep the vcweb hg handler from getting stuck if 'hg serve'
hangs after the request either completes or is canceled.

Fixes #57597 (maybe).

Change-Id: I53cf58e8ab953fd48c0c37f596f99e885a036d9b
Reviewed-on: https://go-review.googlesource.com/c/go/+/460997
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/go/internal/vcweb/hg.go