]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: include close notify in client tls test recordings
authorRyan Granger <rygrange@cisco.com>
Fri, 11 Oct 2024 16:53:56 +0000 (16:53 +0000)
committerGopher Robot <gobot@golang.org>
Wed, 16 Oct 2024 13:37:50 +0000 (13:37 +0000)
commit24cb743d1faa6c8f612faa3c17ac9de5cc385832
tree117ffe80436e40fc02f78675d5baa8a33cd0d1e6
parent70f4717e96cf9d8ca8a5f439d7d6487ec822ce49
crypto/tls: include close notify in client tls test recordings

This commit fixes the issue where tls testdata recordings made with the
newer version of the prerecorded tls conversation test harness, doesn't
end up capturing the final close notify message. The fix simply ensures
that the tls.Client closes before the recording of the conversation is
closed. The closing of the client connection directly is no longer
needed when updating the recording since it will be closed when the
tls.Client is closed.

Fixes golang/go#69846

Change-Id: I93898de32abd89659a32ed240df6daea5aeaa7fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/620395
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/crypto/tls/handshake_client_test.go