]> Cypherpunks repositories - gostls13.git/commit
runtime: skip wb call in growslice when unnecessary
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 22 Mar 2019 21:51:33 +0000 (14:51 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Mon, 25 Mar 2019 17:11:46 +0000 (17:11 +0000)
commit24f846e21240f6d6ab2ca23fe319230b7d7f8168
treeec155f1507cfc0a537c56a603e6225e34d785edc
parent2034fbab5b1d11bc59cb476bc3f49ee1b344839d
runtime: skip wb call in growslice when unnecessary

Instrumenting make.bash reveals that almost half (49.54%)
of the >16 million calls to growslice for
pointer-containing slices are
growing from an empty to a non-empty slice.

In that case, there is no need to call the write barrier,
which does some work before discovering that no pointers need shading.

Change-Id: Ide741468d8dee7ad43ea0bfbea6ccdf680030a0f
Reviewed-on: https://go-review.googlesource.com/c/go/+/168959
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/runtime/slice.go