]> Cypherpunks repositories - gostls13.git/commit
runtime: remove maxstring
authorMartin Möhrmann <martisch@uos.de>
Tue, 6 Sep 2016 08:38:16 +0000 (10:38 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 8 Sep 2016 15:57:01 +0000 (15:57 +0000)
commit252093f1203da13e1face4f71141ac75482ccf11
tree85b2a2d2399fe7b419db10c440ba6f34a3d7c450
parentfd975c6aa535f2aa066653235be992731d691cfb
runtime: remove maxstring

Before this CL the runtime prevented printing of overlong strings with the print
function when the length of the string was determined to be corrupted.
Corruption was checked by comparing the string size against the limit
which was stored in maxstring.

However maxstring was not updated everywhere were go strings were created
e.g. for string constants during compile time. Thereby the check for maximum
string length prevented the printing of some valid strings.

The protection maxstring provided did not warrant the bookkeeping
and global synchronization needed to keep maxstring updated to the
correct limit everywhere.

Fixes #16999

Change-Id: I62cc2f4362f333f75b77f199ce1a71aac0ff7aeb
Reviewed-on: https://go-review.googlesource.com/28813
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/export_test.go
src/runtime/print.go
src/runtime/string.go
src/runtime/string_test.go