]> Cypherpunks repositories - gostls13.git/commit
cmd/go: factor the I/O-retry logic out of renameio
authorBryan C. Mills <bcmills@google.com>
Mon, 10 Jun 2019 16:01:49 +0000 (12:01 -0400)
committerBryan C. Mills <bcmills@google.com>
Thu, 13 Jun 2019 15:09:42 +0000 (15:09 +0000)
commit25a2b98f7a1454aac0d7d3072f74613ac0446630
tree44a3b4059368213e0533d83e0ecec6eb98d300f7
parent55d31e16c12c38d36811bdee65ac1f7772148250
cmd/go: factor the I/O-retry logic out of renameio

Factor the try-on-failure variants are now in the package
cmd/go/internal/robustio.

Add to them a RemoveAll variant using the same retry loop,
and use it to attempt to address the observed flakes in
TestLinkXImportPathEscape.

Fixes #19491
Updates #25965
Updates #28387
Updates #32188

Change-Id: I9db1a0c7537b8aaadccab1b9eca734595668ba29
Reviewed-on: https://go-review.googlesource.com/c/go/+/181541
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/go/go_test.go
src/cmd/go/go_windows_test.go
src/cmd/go/internal/renameio/renameio.go
src/cmd/go/internal/renameio/renameio_test.go
src/cmd/go/internal/robustio/robustio.go [new file with mode: 0644]
src/cmd/go/internal/robustio/robustio_other.go [moved from src/cmd/go/internal/renameio/rename.go with 84% similarity]
src/cmd/go/internal/robustio/robustio_windows.go [moved from src/cmd/go/internal/renameio/rename_windows.go with 88% similarity]
src/cmd/go/script_test.go