]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.25] archive/tar: set a limit on the size of GNU sparse file 1...
authorDamien Neil <dneil@google.com>
Thu, 11 Sep 2025 20:32:10 +0000 (13:32 -0700)
committerGopher Robot <gobot@golang.org>
Tue, 7 Oct 2025 18:04:24 +0000 (11:04 -0700)
commit2612dcfd3cb6dd73c76e14a24fe1a68e2708e4e3
tree3eba9ce49b587f87119641468f713f6aa15ece32
parent90f72bd5001d0278949fab0b7a40f7d8c712979b
[release-branch.go1.25] archive/tar: set a limit on the size of GNU sparse file 1.0 regions

Sparse files in tar archives contain only the non-zero components
of the file. There are several different encodings for sparse
files. When reading GNU tar pax 1.0 sparse files, archive/tar did
not set a limit on the size of the sparse region data. A malicious
archive containing a large number of sparse blocks could cause
archive/tar to read an unbounded amount of data from the archive
into memory.

Since a malicious input can be highly compressable, a small
compressed input could cause very large allocations.

Cap the size of the sparse block data to the same limit used
for PAX headers (1 MiB).

Thanks to Harshit Gupta (Mr HAX) (https://www.linkedin.com/in/iam-harshit-gupta/)
for reporting this issue.

Fixes CVE-2025-58183
For #75677
Fixes #75711

Change-Id: I70b907b584a7b8676df8a149a1db728ae681a770
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2800
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/2987
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/709852
TryBot-Bypass: Michael Pratt <mpratt@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
src/archive/tar/common.go
src/archive/tar/reader.go
src/archive/tar/reader_test.go
src/archive/tar/testdata/gnu-sparse-many-zeros.tar.bz2 [new file with mode: 0644]