]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: omit file:pos for non-existent errors
authorEmmanuel T Odeke <emmanuel@orijtech.com>
Thu, 30 Apr 2020 03:55:22 +0000 (20:55 -0700)
committerRobert Griesemer <gri@golang.org>
Fri, 8 May 2020 20:28:57 +0000 (20:28 +0000)
commit26de581a709428d55ffc38cc0dbc7ddfc96b9443
treee026dfeda47929cda82aa68f0636024b7694a170
parent8f4be42b37469d7c392c330ac13599a88d5c9ea2
cmd/compile: omit file:pos for non-existent errors

Omits printing the file:line:column when trying to
open non-existent files

Given:
    go tool compile x.go

* Before:
    x.go:0: open x.go: no such file or directory

* After:
    open x.go: no such file or directory

Reverts the revert in CL 231043 by only fixing the case
of non-existent errors which is what the original bug
was about. The fix for "permission errors" will come later
on when I have bandwidth to investigate the differences
between running with root and why os.Open works for some
builders and not others.

Fixes #36437

Change-Id: I9c8a0981ad708b504bb43990a4105b42266fa41f
Reviewed-on: https://go-review.googlesource.com/c/go/+/230941
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/gc/noder.go
src/cmd/compile/internal/gc/subr.go
test/fixedbugs/issue36437.go [new file with mode: 0644]