]> Cypherpunks repositories - gostls13.git/commit
crypto/internal/fips140test: add DetECDSA ACVP tests
authorDaniel McCarney <daniel@binaryparadox.net>
Wed, 11 Dec 2024 21:31:22 +0000 (16:31 -0500)
committerGopher Robot <gobot@golang.org>
Fri, 7 Feb 2025 16:57:41 +0000 (08:57 -0800)
commit273db12ceeef8ec74f437ec097474eeda587485d
tree609bab1d4a05349f4736deae5c3d58c419cd9e98
parent78132a1f5731fcca5d2ee4535cebc15741946d1e
crypto/internal/fips140test: add DetECDSA ACVP tests

Adds ACVP test coverage for deterministic ECDSA based on the NIST spec:
  https://pages.nist.gov/ACVP/draft-fussell-acvp-ecdsa.html

Notably there is no corresponding acvp_test.config.json update in this
commit because ACVP DetECDSA only specifies sigGen mode.

The ACVP ECDSA sigGen tests are not amenable to testing against
static data because the test vectors don't provide a key pair to use for
the signature, just the message. The module wrapper has to generate its
own keypair and return the public key components with the signature.
DetECDSA produces deterministic signatures only when signing the same
message with the same key.

Change-Id: I9921f52e943c96b32e02e79cb5556ba0fabeae17
Reviewed-on: https://go-review.googlesource.com/c/go/+/635341
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
src/crypto/internal/fips140test/acvp_capabilities.json
src/crypto/internal/fips140test/acvp_test.go