]> Cypherpunks repositories - gostls13.git/commit
cmd/go: remove -w workaround for -buildmode=plugin on Darwin
authorThan McIntosh <thanm@google.com>
Fri, 8 Nov 2019 21:11:44 +0000 (16:11 -0500)
committerThan McIntosh <thanm@google.com>
Mon, 11 Nov 2019 17:44:21 +0000 (17:44 +0000)
commit275a7be3da9fded6ec71c92633bca30caf6dd93b
treea7ea222fbf0f18f59cb2669be132e16452993f4e
parent795e8c2317a6a4d728a59caa7550312cdceab367
cmd/go: remove -w workaround for -buildmode=plugin on Darwin

The problem causing the assert in #21647 are fixed at this point,
along with various other linker issues with plugin + Darwin. With
this in mind, remove the "-ldflags=-w" workaround for plugin mode on
Darwin and re-enable the appropriate tests misc/cgo/testplugin

Fixes #21647.
Fixes #27502.

Change-Id: I5b662987b138b06cfc9e1f9f6d804cf682bd501a
Reviewed-on: https://go-review.googlesource.com/c/go/+/206198
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
misc/cgo/testplugin/plugin_test.go
src/cmd/go/internal/work/init.go