]> Cypherpunks repositories - gostls13.git/commit
misc/wasm: make sure value ref id is unique
authorCherry Zhang <cherryyz@google.com>
Sat, 30 Jun 2018 03:09:34 +0000 (23:09 -0400)
committerCherry Zhang <cherryyz@google.com>
Sun, 1 Jul 2018 21:36:23 +0000 (21:36 +0000)
commit28f9b880f6e9f95c61b31b6e0a7ac458cb6a0e0c
tree19700f31520a82ef4f0e730a9bfe12193e0d449f
parent6780042f0a30569abcc3c5e9e0376761ac928ef5
misc/wasm: make sure value ref id is unique

For each Javascript object that returns to Go as a js.Value, we
associate the ref id to it. But if this ref id is copied or
inherited to other object, it would mess up the ref-object
mapping.

In storeValue, make sure the object is indeed the one we are
storing. Otherwise allocate a new ref id.

Fixes #26143.

Change-Id: Ie60bb2f8d1533da1bbe6f46045866515ec2af5a9
Reviewed-on: https://go-review.googlesource.com/121835
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Richard Musiol <neelance@gmail.com>
misc/wasm/wasm_exec.js
src/syscall/js/js_test.go