]> Cypherpunks repositories - gostls13.git/commit
net/http: fix request canceler leak on connection close
authorAlexander Yastrebov <yastrebov.alex@gmail.com>
Tue, 22 Aug 2023 21:14:14 +0000 (21:14 +0000)
committerDamien Neil <dneil@google.com>
Tue, 22 Aug 2023 22:22:23 +0000 (22:22 +0000)
commit291a32aa4bd894eaad0517ce1ac3e04dd885cb8b
tree8718228324a724ade26868024b8f6250309bab36
parent4dc2564933146efc411efad16b662589306744d1
net/http: fix request canceler leak on connection close

Due to a race condition persistConn could be closed without removing request canceler.

Note that without the fix test occasionally passes and to demonstrate the issue it has to be run multiple times, e.g. using -count=10.

Fixes #61708

Change-Id: I9029d7d65cf602dd29ee1b2a87a77a73e99d9c92
GitHub-Last-Rev: 6b31f9826da71dad4ee8c0491efba995a8f51440
GitHub-Pull-Request: golang/go#61745
Reviewed-on: https://go-review.googlesource.com/c/go/+/515796
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/net/http/transport.go
src/net/http/transport_test.go