]> Cypherpunks repositories - gostls13.git/commit
[dev.cc] cmd/asm: check for overflow on multiply and left shift
authorRob Pike <r@golang.org>
Wed, 28 Jan 2015 21:34:13 +0000 (13:34 -0800)
committerRob Pike <r@golang.org>
Wed, 28 Jan 2015 22:26:41 +0000 (22:26 +0000)
commit29428e322d6f4eaccb7636e93f31f20cffcf7377
treed8a46a98f27edff3ed6f5863bfdd21de837a8c44
parent0012b83507f06d5ecb95cf40170b539d58f35881
[dev.cc] cmd/asm: check for overflow on multiply and left shift

The internal size of integers is not part of the definition of the assembler,
so if bits roll out the top it's a portability problem at best.

If you need to use shift to create a mask, use & to restrict the bit count
before shifting. That will make it portable, too.

Change-Id: I24f9a4d2152c3f9f253e22ff75270fe50c18612b
Reviewed-on: https://go-review.googlesource.com/3451
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/asm/internal/asm/overflow.go
src/cmd/asm/internal/asm/parse.go