]> Cypherpunks repositories - gostls13.git/commit
runtime: use funcID to identify abort in isAbortPC
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 5 Apr 2021 19:13:34 +0000 (19:13 +0000)
committerMichael Knyszek <mknyszek@google.com>
Tue, 6 Apr 2021 03:31:26 +0000 (03:31 +0000)
commit298975c634758ee464dc0629402107bfc33c4b41
tree56287ed3cdf8e56e7609ccd89c275ead5a669c81
parentb2389ad3ce7254784db5f4005805714e87ffab85
runtime: use funcID to identify abort in isAbortPC

This change eliminates the use of funcPC to determine if an PC is in
abort. Using funcPC for this purpose is problematic when using plugins
because symbols no longer have unique PCs. funcPC also grabs the wrapper
for runtime.abort which isn't what we want for the new register ABI, so
rather than mark runtime.abort as ABIInternal, use funcID.

For #40724.

Change-Id: I2730e99fe6f326d22d64a10384828b94f04d101a
Reviewed-on: https://go-review.googlesource.com/c/go/+/307391
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/internal/objabi/funcid.go
src/runtime/panic.go
src/runtime/symtab.go