]> Cypherpunks repositories - gostls13.git/commit
runtime: fix preemption deadlocks in TestDebugCall*
authorAustin Clements <austin@google.com>
Wed, 23 May 2018 18:01:21 +0000 (14:01 -0400)
committerAustin Clements <austin@google.com>
Thu, 24 May 2018 15:39:56 +0000 (15:39 +0000)
commit29957c52df59795ba21a6832662f66e9f1f298cf
treeb683e2cf750da2578f68a0782a133748fd74f366
parent65c365bf0f4add682419ba8fe68db43a0cab0e83
runtime: fix preemption deadlocks in TestDebugCall*

TestDebugCall* uses atomic spin loops and hence can deadlock if the
garbage collector is enabled (because of #10958; ironically,
implementing debugger call injection is closely related to fixing this
exact issue, but we're not there yet).

Fix this by disabling the garbage collector during these tests.

Updates #25519 (might fix it, though I suspect not)

Change-Id: If1e454b9cdea8e4b1cd82509b762c75b6acd8476
Reviewed-on: https://go-review.googlesource.com/114086
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/runtime/debug_test.go