]> Cypherpunks repositories - gostls13.git/commit
cmd/go: always log dynamic import errors
authorBurcu Dogan <jbd@google.com>
Mon, 12 Oct 2015 08:02:51 +0000 (01:02 -0700)
committerAndrew Gerrand <adg@golang.org>
Mon, 12 Oct 2015 23:59:09 +0000 (23:59 +0000)
commit29aaf679daa52e877c6596422a06916c343dae41
tree6b695256f93c0ed939584c87117600e246283b6c
parent5b9c6b9e9e645742f6f1a7552f9fc1113178c514
cmd/go: always log dynamic import errors

There is no easy way to understand what user intent was and whether
they wanted to use a dynamic import or not.

If we skip logging such errors, it breaks common use cases such as
https://golang.org/issue/12810.

It's a better approach to expose the underlying mechanism and
be more verbose with the error messages.

Fixes #12810.

Change-Id: I7e922c9e848382690d9d9b006d7046e6cf93223b
Reviewed-on: https://go-review.googlesource.com/15756
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
src/cmd/go/vcs.go