]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/modfetch: pass "-c" arguments to git before subcommands
authorBryan C. Mills <bcmills@google.com>
Wed, 6 Mar 2024 22:50:45 +0000 (17:50 -0500)
committerGopher Robot <gobot@golang.org>
Mon, 11 Mar 2024 22:10:38 +0000 (22:10 +0000)
commit2ab9218c86ed625362df5060f64fcd59398a76f3
tree68fe684362654b203b33020007533176363ca2cc
parenta18aa0e3d14271659398648a49e54683ded4456c
cmd/go/internal/modfetch: pass "-c" arguments to git before subcommands

I accidentally transposed the arguments in CL 556358, causing the
shallow 'git fetch' attempt to always fail. That didn't break any
tests because we fall back to a full fetch, which works for nearly all
real Git servers, and we didn't have a test that checked for shallow
fetches.

Tested manually using:
GOPROXY=direct go mod download -x -json gerrit.wikimedia.org/r/mediawiki@v0.0.0-20240202145822-67da0cbcfdf7

(I'm still thinking about how to add a proper regression test.)

Fixes #66147.

Change-Id: I0bb17283bae856f369fd24f29375e507d0999933
Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64-longtest,gotip-linux-amd64-longtest,gotip-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/569422
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/go/internal/modfetch/codehost/git.go
src/cmd/go/testdata/script/reuse_git.txt