]> Cypherpunks repositories - gostls13.git/commit
[dev.ssa] cmd/compile: fix function call memory accounting
authorJosh Bleecher Snyder <josharian@gmail.com>
Tue, 11 Aug 2015 21:23:08 +0000 (14:23 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 11 Aug 2015 21:51:16 +0000 (21:51 +0000)
commit2af06480140dd48a4dc54257c2da46a73ca3ebb5
tree732d0f8e961684ea8a76494dfdd7464b93a00493
parent40aba8c4e7ac5babf9901d1948ff56c117e3bcf9
[dev.ssa] cmd/compile: fix function call memory accounting

We were not recording function calls as
changing the state of memory.

As a result, the scheduler was not aware that
storing values to the stack in order to make a
function call must happen *after* retrieving
results from the stack from a just-completed
function call.

This fixes the container/ring tests.

This was my first experience debugging an issue
using the HTML output. I'm feeling quite
pleased with it.

Change-Id: I9e8276846be9fd7a60422911b11816c5175e3d0a
Reviewed-on: https://go-review.googlesource.com/13560
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/ssa.go