]> Cypherpunks repositories - gostls13.git/commit
spec: split shift examples into groups for 32- and 64-bit ints
authorRobert Griesemer <gri@golang.org>
Wed, 7 Oct 2020 18:33:11 +0000 (11:33 -0700)
committerRobert Griesemer <gri@golang.org>
Fri, 30 Oct 2020 16:20:05 +0000 (16:20 +0000)
commit2b9b2720b89d493dbf8725d0ae6664ac7835b3af
tree1761e932d3dfa9271d54c6e17c979db5836b3b51
parent256d729c0b272021a44f61f47cd2c9c6d9fb1722
spec: split shift examples into groups for 32- and 64-bit ints

In the current (pre-CL) version of the spec, the 2nd last shift
example appears to be using the array declared in the last example.
On a 32-bit platform, that array would have length 0, which would
lead to a panic in the 2nd last example. Also, if this code were
inside a function, it wouldn't compile (array declared after use).

Use an explicitly declared array for that specific shift example.
Also, split out all cases that produce different results for 32-
vs 64-bit ints.

Fixes #41835.

Change-Id: Ie45114224509e4999197226f91f7f6f934449abb
Reviewed-on: https://go-review.googlesource.com/c/go/+/260398
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
doc/go_spec.html