]> Cypherpunks repositories - gostls13.git/commit
all: respect $GO_GCFLAGS during run.bash
authorRuss Cox <rsc@golang.org>
Mon, 30 Oct 2017 19:28:11 +0000 (15:28 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 31 Oct 2017 13:19:15 +0000 (13:19 +0000)
commit2beb173e9858c966a1db351883cfdccc8cdca583
tree247c00c4683d3d45a959b902484cf41409428de3
parent99be9cc02cdb42d692a5889500e1b68d6155ae62
all: respect $GO_GCFLAGS during run.bash

If the go install doesn't use the same flags as the main build
it can overwrite the installed standard library, leading to
flakiness and slow future tests.

Force uses of 'go install' etc to propagate $GO_GCFLAGS
or disable them entirely, to avoid problems.

As I understand it, the main place this happens is the ssacheck builder.
If there are other uses that need to run some of the now-disabled
tests we can reenable fixed tests in followup CLs.

Change-Id: Ib860a253539f402f8a96a3c00ec34f0bbf137c9a
Reviewed-on: https://go-review.googlesource.com/74470
Reviewed-by: David Crawshaw <crawshaw@golang.org>
src/cmd/dist/test.go
src/cmd/go/go_test.go
src/cmd/internal/goobj/goobj_test.go
src/internal/testenv/testenv.go
src/runtime/crash_test.go
test/run.go