]> Cypherpunks repositories - gostls13.git/commit
cmd/go: propagate context into PackagesForBuild and Do for tracing
authorMichael Matloob <matloob@golang.org>
Wed, 17 Jun 2020 19:50:14 +0000 (15:50 -0400)
committerMichael Matloob <matloob@golang.org>
Wed, 12 Aug 2020 18:35:45 +0000 (18:35 +0000)
commit2bfa45cfa994512c47da2d98f3baca5bb474ec9b
tree778bf0b657ea89fd96c28c467f2f2e1d0054b7b8
parent14715b24793176b30b3c41adf4ac4e676c2a56f0
cmd/go: propagate context into PackagesForBuild and Do for tracing

This change propagates context into PackagesForErrors and Do for
the purpose of tracing, and calls trace.StartSpan on PackagesForErrors
and Do, so that the trace now shows the broad outline of where
the "Loading" and "Execution" phases are in the build.

Updates #38714

Change-Id: Ib9a7cf7030210f68f76663d1c8a7461e0a226611
Reviewed-on: https://go-review.googlesource.com/c/go/+/238541
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
13 files changed:
src/cmd/go/internal/clean/clean.go
src/cmd/go/internal/fix/fix.go
src/cmd/go/internal/fmtcmd/fmt.go
src/cmd/go/internal/generate/generate.go
src/cmd/go/internal/get/get.go
src/cmd/go/internal/list/list.go
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/modget/get.go
src/cmd/go/internal/run/run.go
src/cmd/go/internal/test/test.go
src/cmd/go/internal/vet/vet.go
src/cmd/go/internal/work/build.go
src/cmd/go/internal/work/exec.go