]> Cypherpunks repositories - gostls13.git/commit
http: change ResponseWriter.SetHeader(k,v) to Header() accessor
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 9 Mar 2011 17:41:01 +0000 (09:41 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 9 Mar 2011 17:41:01 +0000 (09:41 -0800)
commit2c420ece67e25c7692e28f641d374deb0bec9b7d
treed65b746c5fa2c4439e271d4d86f7fd020854e6c9
parentfe8639a9fbe27839e99ee97b749dee6699a84eeb
http: change ResponseWriter.SetHeader(k,v) to Header() accessor

Caller code needs to change:

rw.SetHeader("Content-Type", "text/plain")
to:
rw.Header().Set("Content-Type", "text/plain")

This now permits returning multiple headers
with the same name using Add:

rw.Header().Add("Set-Cookie", "..")
rw.Header().Add("Set-Cookie", "..")

This patch also fixes serialization of headers, removing newline characters.

Fixes #488
Fixes #914

R=rsc
CC=gburd, golang-dev
https://golang.org/cl/4239076
16 files changed:
src/cmd/godoc/godoc.go
src/cmd/godoc/main.go
src/pkg/expvar/expvar.go
src/pkg/http/cgi/child.go
src/pkg/http/cgi/host.go
src/pkg/http/cgi/host_test.go
src/pkg/http/cgi/matryoshka_test.go
src/pkg/http/fs.go
src/pkg/http/httptest/recorder.go
src/pkg/http/pprof/pprof.go
src/pkg/http/response.go
src/pkg/http/responsewrite_test.go
src/pkg/http/serve_test.go
src/pkg/http/server.go
src/pkg/http/triv.go
src/pkg/rpc/server.go