]> Cypherpunks repositories - gostls13.git/commit
encoding/xml: do not ignore error return from copyValue
authorEric Lagergren <ericscottlagergren@gmail.com>
Sat, 20 Aug 2016 22:46:06 +0000 (15:46 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 22 Aug 2016 18:01:47 +0000 (18:01 +0000)
commit2c58cb36f971aed484e880769eb2b0a21654459a
treeb70939aa7b0257cf033d99c8d9780d809e117835
parent747a158ef314bb458b90da95f3e3d67aa4140622
encoding/xml: do not ignore error return from copyValue

The error return from copyValue was ignored causing some XML attribute
parsing to swallow an error.

Additionally, type MyMarshalerAttrTest had no UnmarshalXMLAttr method
causing marshalTests not to be symmetrical and the test suite to fail
for test case 101.

Fixes #16158

Change-Id: Icebc505295a2c656ca4b42ba37bb0957dd7260c6
Reviewed-on: https://go-review.googlesource.com/27455
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/encoding/xml/marshal_test.go
src/encoding/xml/read.go