]> Cypherpunks repositories - gostls13.git/commit
net/http: remove an allocation in ServeMux
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 5 Jun 2018 21:06:17 +0000 (21:06 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 6 Jun 2018 01:47:31 +0000 (01:47 +0000)
commit2ce295e9542c104110a050bf809dd0a37e191eb7
treee4708bd69c995300c4ead215d4bca14d196e13a9
parentebb8a1f8e6bf14ce4773e930870985571aaff932
net/http: remove an allocation in ServeMux

Also, add a benchmark variant ("SkipServe") that only benchmarks the
ServeMux handler selection path.

name                  old time/op    new time/op    delta
ServeMux_SkipServe-4    74.2µs ± 2%    60.6µs ± 1%   -18.31%   (p=0.000 n=10+9)

name                  old alloc/op   new alloc/op   delta
ServeMux_SkipServe-4    2.62kB ± 0%   0.00kB ±NaN%  -100.00%  (p=0.000 n=10+10)

name                  old allocs/op  new allocs/op  delta
ServeMux_SkipServe-4       180 ± 0%        0 ±NaN%  -100.00%  (p=0.000 n=10+10)

Updates #25383

Change-Id: Icfbb3b977e309093d032e922d1b4f254df6f5955
Reviewed-on: https://go-review.googlesource.com/116378
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
src/net/http/serve_test.go
src/net/http/server.go