]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.8] cmd/link: emit a mach-o dwarf segment that dsymutil will accept
authorRuss Cox <rsc@golang.org>
Thu, 30 Mar 2017 00:50:34 +0000 (20:50 -0400)
committerAustin Clements <austin@google.com>
Wed, 5 Apr 2017 16:58:35 +0000 (16:58 +0000)
commit2d0043014fe397a957f6a85a86c12ffcc0eaef86
tree865b0f9723f39a07ed6018cc23e2f32029c6cdd2
parent3ca0d34fa12abad8fc5ca8b8fabec0c1b2c0d288
[release-branch.go1.8] cmd/link: emit a mach-o dwarf segment that dsymutil will accept

Right now, at least with Xcode 8.3, we invoke dsymutil and dutifully
copy what it produces back into the binary, but it has actually dropped
all the DWARF information that we wanted, because it didn't like
the look of go.o.

Make it like the look of go.o.

DWARF is tested in other ways, but typically indirectly and not for cgo programs.
Add a direct test, and one that exercises cgo.
This detects missing dwarf information in cgo-using binaries on macOS,
at least with Xcode 8.3, and possibly earlier versions as well.

Fixes #19772.

The backport to Go 1.8 disables TestDWARF on Windows because Windows
DWARF support is new in Go 1.9.

Change-Id: I0082e52c0bc8fc4e289770ec3dc02f39fd61e743
Reviewed-on: https://go-review.googlesource.com/39605
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/link/dwarf_test.go [new file with mode: 0644]
src/cmd/link/internal/ld/lib.go
src/cmd/link/internal/ld/macho.go