]> Cypherpunks repositories - gostls13.git/commit
runtime: don't create heap hints outside TSAN's supported heap
authorAustin Clements <austin@google.com>
Fri, 13 Jul 2018 21:29:39 +0000 (17:29 -0400)
committerAustin Clements <austin@google.com>
Thu, 19 Jul 2018 18:12:51 +0000 (18:12 +0000)
commit2d4c1ff73992fa817213c7866be8030d9c78b5ba
tree5e82b6823b86b6c26a5ea0473c8f55faaa8d0af6
parent59d0baeb335647663b135a52af5d345d989f218f
runtime: don't create heap hints outside TSAN's supported heap

TSAN for Go only supports heap address in the range [0x00c000000000,
0x00e000000000). However, we currently create heap hints of the form
0xXXc000000000 for XX between 0x00 and 0x7f. Even for XX=0x01, this
hint is outside TSAN's supported heap address range.

Fix this by creating a slightly different set of hints in race mode,
all of which fall inside TSAN's heap address range.

This should fix TestArenaCollision flakes. That test forces the
runtime to use later heap hints. Currently, this always results in
TSAN "failed to allocate" failures on Windows (which happens to have a
slightly more constrained TSAN layout than non-Windows). Most of the
time we don't notice these failures, but sometimes it crashes TSAN,
leading to a test failure.

Fixes #25698.

Change-Id: I8926cd61f0ee5ee00efa77b283f7b809c555be46
Reviewed-on: https://go-review.googlesource.com/123780
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rick Hudson <rlh@golang.org>
src/runtime/malloc.go