]> Cypherpunks repositories - gostls13.git/commit
crypto/elliptic: fix incomplete addition used in CombinedMult.
authorAdam Langley <agl@golang.org>
Thu, 4 May 2017 01:20:12 +0000 (18:20 -0700)
committerAdam Langley <agl@golang.org>
Mon, 11 Sep 2017 18:44:58 +0000 (18:44 +0000)
commit2d69e9e259ec0f5d5fbeb3498fbd9fed135fe869
treef731ea4b4c0e17f4a3b3a5cdb99f20b8132c2681
parent7159ab4871793b844da21538b3a8298d0646935b
crypto/elliptic: fix incomplete addition used in CombinedMult.

The optimised P-256 includes a CombinedMult function, which doesn't do
dual-scalar multiplication, but does avoid an affine conversion for
ECDSA verification.

However, it currently uses an assembly point addition function that
doesn't handle exceptional cases.

Fixes #20215.

Change-Id: I4ba2ca1a546d883364a9bb6bf0bdbc7f7b44c94a
Reviewed-on: https://go-review.googlesource.com/42611
Run-TryBot: Adam Langley <agl@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
src/crypto/ecdsa/ecdsa_test.go
src/crypto/elliptic/elliptic_test.go
src/crypto/elliptic/p256_amd64.go
src/crypto/elliptic/p256_asm_amd64.s