]> Cypherpunks repositories - gostls13.git/commit
runtime/trace: enable frame pointer unwinding by default for amd64 and arm64
authorNick Ripley <nick.ripley@datadoghq.com>
Mon, 1 May 2023 13:08:01 +0000 (09:08 -0400)
committerGopher Robot <gobot@golang.org>
Tue, 2 May 2023 15:36:11 +0000 (15:36 +0000)
commit2d83b646d677ceb3df2ea592b7938efe8214c52a
treef89c1a355cd6020b4ee3d858cd44ef39c7d730a0
parentc63066123bb5c2ef7a6d26d1a6e3e5f1012a1e23
runtime/trace: enable frame pointer unwinding by default for amd64 and arm64

Re-enable frame pointer unwinding for execution tracing on amd64 by
default, now that CL 489015 and CL 488755 have fixed recently-discovered
crashes. This reverts CL 486382.

These fixes, together with CL 241158 to fix up frame pointers when
copying stacks on arm64, also make frame pointer unwinding for tracing
safe to enable for arm64. This should significantly reduce the CPU and
latency overhead of execution tracing on arm64, as it has for amd64.

Co-Authored-By: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Change-Id: I64a88bd69dfd8cb13956ec46f8b1203dbeaa26a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/490815
Reviewed-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Run-TryBot: Nick Ripley <nick.ripley@datadoghq.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
src/runtime/runtime1.go
src/runtime/trace.go