]> Cypherpunks repositories - gostls13.git/commit
runtime: make slice growth formula a bit smoother
authorKeith Randall <khr@golang.org>
Tue, 7 Sep 2021 16:44:29 +0000 (09:44 -0700)
committerKeith Randall <khr@golang.org>
Mon, 27 Sep 2021 20:53:51 +0000 (20:53 +0000)
commit2dda92ff6f9f07eeb110ecbf0fc2d7a0ddd27f9d
tree360ba410092470d549d245a35c825069816e8cda
parent301f6c8019bea813b039c3d376a6464a0e117dce
runtime: make slice growth formula a bit smoother

Instead of growing 2x for < 1024 elements and 1.25x for >= 1024 elements,
use a somewhat smoother formula for the growth factor. Start reducing
the growth factor after 256 elements, but slowly.

starting cap    growth factor
256             2.0
512             1.63
1024            1.44
2048            1.35
4096            1.30

(Note that the real growth factor, both before and now, is somewhat
larger because we round up to the next size class.)

This CL also makes the growth monotonic (larger initial capacities
make larger final capacities, which was not true before). See discussion
at https://groups.google.com/g/golang-nuts/c/UaVlMQ8Nz3o

256 was chosen as the threshold to roughly match the total number of
reallocations when appending to eventually make a very large
slice. (We allocate smaller when appending to capacities [256,1024]
and larger with capacities [1024,...]).

Change-Id: I876df09fdc9ae911bb94e41cb62675229cb10512
Reviewed-on: https://go-review.googlesource.com/c/go/+/347917
Trust: Keith Randall <khr@golang.org>
Trust: Martin Möhrmann <martin@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Martin Möhrmann <martin@golang.org>
src/reflect/value.go
src/runtime/slice.go