]> Cypherpunks repositories - gostls13.git/commit
runtime: fix unsafe.Pointer alignment on Linux
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sat, 19 Oct 2019 08:18:34 +0000 (15:18 +0700)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 22 Oct 2019 01:03:09 +0000 (01:03 +0000)
commit2e1a6a28dfcc57ad6a14c9c27a81ee37b9b6f874
tree8aa1f8ac5ed6db3693353d4cc5242295f6c3ee8d
parent0050c079d5a50e441aa32d0da5338687890194ef
runtime: fix unsafe.Pointer alignment on Linux

Caught by go test -a -short -gcflags=all=-d=checkptr runtime

TestMincoreErrorSign intentionally uses uintptr(1) to get -EINVAL,
but it violates unsafe pointer rules 2. So use another misaligned
pointer add(new(int32), 1), but do not violate unsafe pointer rules.

TestEpollctlErrorSign passes an unsafe.Pointer of &struct{}{} to
Epollctl, which is then casted to epollevent, causes mis-alignment.
Fixing it by exporting epollevent on runtime_test package, so it can be
passed to Epollctl.

Updates #34972

Change-Id: I78ebfbeaf706fd1d372272af0bbc4e2cabca4631
Reviewed-on: https://go-review.googlesource.com/c/go/+/202157
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/export_linux_test.go
src/runtime/runtime_linux_test.go