]> Cypherpunks repositories - gostls13.git/commit
cmd/yacc: adjust expansion of $n to be more useful in errors
authorRuss Cox <rsc@golang.org>
Fri, 6 Feb 2015 18:48:42 +0000 (13:48 -0500)
committerRuss Cox <rsc@golang.org>
Fri, 13 Feb 2015 17:29:36 +0000 (17:29 +0000)
commit2e78447bafc2dfdfa8b75e01ca3e681741706bbc
tree43586b33a54fa10e00e5f07254fc5540aa923a50
parent3be158d6ab73090a74df6bc3b7cfa062d896483a
cmd/yacc: adjust expansion of $n to be more useful in errors

When the compiler echoes back an expression, it shows the
generated yacc expression. Change the generated code to
use a slice so that $3 shows up as yyDollar[3] in such messages.

Consider changing testdata/expr/expr.y to say:

$$.Sub(float64($1), $3)

(The float64 conversion is incorrect.)

Before:
expr.y:70[expr.go:486]: cannot convert exprS[exprpt - 2].num (type *big.Rat) to type float64

After:
expr.y:70[expr.go:492]: cannot convert exprDollar[1].num (type *big.Rat) to type float64

Change-Id: I74e494069df588e62299d1fccb282f3658d8f8f4
Reviewed-on: https://go-review.googlesource.com/4630
Reviewed-by: Rob Pike <r@golang.org>
src/cmd/yacc/yacc.go