]> Cypherpunks repositories - gostls13.git/commit
cmd/go: do not attempt to install cmd/addr2line in TestScript/mod_outside
authorBryan C. Mills <bcmills@google.com>
Wed, 18 Jan 2023 15:08:34 +0000 (10:08 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 18 Jan 2023 15:34:40 +0000 (15:34 +0000)
commit2e792a8295d7c7f082cf2e3b163a3d4d30b6df7e
treeb66e818fb09396efba30969be613aa771681b42d
parent7026a8a1a9aba58285b3cae215df04140245b6db
cmd/go: do not attempt to install cmd/addr2line in TestScript/mod_outside

Tests must not write to GOROOT: it might not writable (for example, if
it is owned by root and the user is non-root), and in general we can't
assume that the configuration in which the test is run matches the
configuration with which the installed tools were built.

In this specific case, CL 454836 (for #57007) installs 'cmd' with
CGO_ENABLED=0, but most builders still run the tests with CGO_ENABLED
unset.

Updates #57007.

Change-Id: I2795fcd3ff61c164dc730b62f697f307ab3a167b
Reviewed-on: https://go-review.googlesource.com/c/go/+/461689
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/go/testdata/script/mod_outside.txt