]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/base: remove MergeEnvLists
authorDaniel Martí <mvdan@mvdan.cc>
Sun, 3 Mar 2019 17:24:57 +0000 (17:24 +0000)
committerDaniel Martí <mvdan@mvdan.cc>
Wed, 13 Mar 2019 13:51:03 +0000 (13:51 +0000)
commit2f02daaa46b2648f464d7c39ff4a1c5ee43631d5
tree89565e5ed92fa0a2cbd2170abe87c8baf7944c5d
parent5f40351708cabe28f90500be87dbe316a2280f4a
cmd/go/internal/base: remove MergeEnvLists

This internally exported function allowed merging environment variable
lists, and was mostly a convenience for the rest of cmd/go/internal.
It seems to date all the way back to 2013.

However, since CL 37586 in early 2017, os/exec has already taken care of
deduplicating environment variable lists. Thus, it's unnecessary for
cmd/go to take care of that before calling exec.Cmd.Start.

Moreover, because os/exec will deduplicate the list in any case, we're
adding extra work in all these scenarios.

Finally, remove an unnecessary addition of GOROOT= in internal/tool.
cfg.OrigEnv may not have the correct GOROOT set up, but os.Environ does;
cmd/go's main function makes sure of that.

Change-Id: I1f92f65fb927dc15bc7b0397cfd1a572b6337bb3
Reviewed-on: https://go-review.googlesource.com/c/go/+/164703
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/go/internal/base/env.go
src/cmd/go/internal/generate/generate.go
src/cmd/go/internal/tool/tool.go
src/cmd/go/internal/work/exec.go