]> Cypherpunks repositories - gostls13.git/commit
test: make a race detector test robust to timing variations
authorDaniel S Fava <danielsfava@gmail.com>
Wed, 9 Dec 2020 22:56:50 +0000 (23:56 +0100)
committerIan Lance Taylor <iant@golang.org>
Mon, 14 Dec 2020 20:30:16 +0000 (20:30 +0000)
commit2f5b1a397454b76ad71e7eda5d574c304a416372
tree0feecd05a55f79c6c7c4afcd9ab7f4538ec1d726
parentc81343ce3aa1b8f1b2539a3d391f628f69a0a490
test: make a race detector test robust to timing variations

The `external_cgo_thread` test in `runtime/race/output_test.go` was
producing intermittent failures.  The test was performing a sleep,
which may not be enough depending on how long it takes to setup the
callBack goroutine.

Added a synchronization to make sure callBack finishes before main ends.

Whether the increment to racy++ happens first in the callBack
or in main doesn't matter: the race detector should flag the race
regardless.  The output check was changed so that the test passes
regardless of which increment occurs first.

Fixes #43008

Change-Id: I325ec3dea52b3725e739fbf2bd7ae92875d2de10
Reviewed-on: https://go-review.googlesource.com/c/go/+/276752
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
src/runtime/race/output_test.go