]> Cypherpunks repositories - gostls13.git/commit
runtime: don't check the exit code in TestWERDialogue
authorqmuntal <quimmuntal@gmail.com>
Wed, 3 May 2023 10:19:58 +0000 (12:19 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Fri, 5 May 2023 07:29:13 +0000 (07:29 +0000)
commit2fd8c5b2d80809040e348a431ff292efbeb6e82c
tree1f87ed8ebdd6d2d147024b35df5146cd61469eec
parente335a2665f5e322a7da8baa22fe816b6ef9aaf24
runtime: don't check the exit code in TestWERDialogue

TestWERDialogue intent is to check that the WER dialog doesn't pop-up
when `GOTRACEBACK=wer` is set. CL 474915 extended the test to also
check the error code of the crashed process. This change is causing
failures in Microsoft internal test pipelines because some WER setups
can modify the exit code of the crashed application, for example to
signal that the crash dump has been collected.

Fix this issue by not checking the error code in TestWERDialogue. Also,
add a new test, TestCrashExitCode, which does the same but using
`GOTRACEBACK=crash` instead, so that we have one test that checks the
error code.

Change-Id: Iedde09e1df7223009ebef38a32a460f1ab07e31a
Reviewed-on: https://go-review.googlesource.com/c/go/+/491935
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
src/runtime/syscall_windows_test.go