]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: limit goroutine count to parallelism
authorRuss Cox <rsc@golang.org>
Tue, 20 Sep 2022 01:48:10 +0000 (21:48 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 29 Sep 2022 16:23:56 +0000 (16:23 +0000)
commit2ff5fbfbd4539d321043e6b84691ecb131402030
tree834ff22108a009d309babb4d1019ed458aa1108a
parent9861e8b2fd83dec24a6ced44998dca52abd6ccff
cmd/compile: limit goroutine count to parallelism

When the compiler crashes, it is not uncommon to see many hundreds
of goroutines all blocked waiting their turn to be one of the nWorkers
goroutines that is allowed to run. All these goroutine stacks are not a
terribly efficient use of memory, and they also make the crash dumps
hard to read.

Introduce a manager goroutine to hand out work to at most nWorker
goroutines, maintaining pending work in a local slice, rather than
having all those blocked goroutines hanging around waiting to run.

Change-Id: I46cb4e1afd6392805f359e14554ebc17d538bcba
Reviewed-on: https://go-review.googlesource.com/c/go/+/431956
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/gc/compile.go