]> Cypherpunks repositories - gostls13.git/commit
cmd/go: explicitly add default GODEBUG to linker config
authorMichael Matloob <matloob@golang.org>
Wed, 4 Sep 2024 19:40:55 +0000 (15:40 -0400)
committerMichael Matloob <matloob@golang.org>
Thu, 12 Sep 2024 14:58:37 +0000 (14:58 +0000)
commit301499ff7babb4a5137069510b16bb51b08af2c6
tree5763c04353e11d74a4b46bcb3aa09d284835001f
parentc1fe637eda9b198cf3acad4eee6db8bc03b602f9
cmd/go: explicitly add default GODEBUG to linker config

Previously we expected the default GODEBUG that's embedded in the binary
to be taken into account for build actionIDs through the build info. The
build info contains the default GODEBUG for a package main, and then
that build info is used to generate the action id. But tests of packages
other than main do not have buildinfo set on them. So the default
GODEBUG isn't taken into account in the action id for those tests.
Explicitly include GODEBUG when generating all link actions' action ids
to make sure it's always present.

Fixes #69203

Change-Id: Ifbc58482454ecfb51ba09cfcff02972cac3270c1
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/610875
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
src/cmd/go/internal/work/exec.go
src/cmd/go/testdata/script/test_default_godebug_issue69203.txt [new file with mode: 0644]